feat(postgresql): surface TransportSchemaName in queue endpoint diagnostics - #2
Draft
uniquelau wants to merge 1 commit into
Draft
feat(postgresql): surface TransportSchemaName in queue endpoint diagnostics#2uniquelau wants to merge 1 commit into
uniquelau wants to merge 1 commit into
Conversation
…ostics PostgresqlQueue did not override Endpoint.DescribeProperties(), so the resolved transport-queue schema was invisible in `wolverine describe` and endpoint diagnostics. Two hosts sharing one Postgres database must set an identical TransportSchemaName; if they diverge the queue tables live in different schemas and messages strand silently (no error, no dead-letter). Override DescribeProperties() to add the resolved schema so the value is observable. Visibility only - no cross-host mismatch assertion or throw. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review copy on our fork — please review before I open this against JasperFx/wolverine. Small, visibility-only diagnostic.
Problem
Two hosts sharing one Postgres database must set an identical transport-queue schema (
TransportSchemaName). If they diverge, the sender writes to its schema's queue tables and the receiver polls a different schema — messages strand with no error and no dead-letter. The resolved schema isn't shown anywhere in diagnostics (PostgresqlQueuedidn't overrideDescribeProperties()), so a misconfiguration is invisible until traffic goes missing.Change (tiny, additive, diagnostic-only)
PostgresqlQueue.DescribeProperties()override — callsbase.DescribeProperties()and adds["TransportSchemaName"] = Parent.TransportSchemaName(the resolved queue schema,QueueTablebinds to exactly this). Follows the existingRabbitMqQueue.DescribeProperties()pattern (call base, add entries).Test
describe_properties_includes_the_resolved_transport_schema(PostgresqlTests) — DB-free unit test: sets a custom schema, constructs the queue, asserts the dictionary carries the key/value. All 10PostgresqlQueueTestspass (net10.0). No database needed.Value: makes a silent-failure mode visible in
wolverine describefor anyone running the shared-database multi-host Postgres-transport pattern. Optional startup log skipped to keep it minimal.